Skip to content

Update ads-client android httpconfig dependency to be behind testImplementation #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
luc-lisi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ads-client android httpconfig dependency to be behind testImplementation #7175

luc-lisi wants to merge 1 commit into from
+1 −1

Conversation

@luc-lisi
Copy link
Contributor

@luc-lisi luc-lisi commented Jan 23, 2026 •
edited
Loading

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

moztcampbell
moztcampbell reviewed Jan 23, 2026
View reviewed changes
Copy link
Collaborator

@moztcampbell moztcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle this similar to remote_settings :

application-services/components/remote_settings/android/build.gradle

Lines 13 to 17 in e4b27ca

if (gradle.hasProperty("mozconfig")) {
testImplementation project(':components:concept-fetch')
} else {
testImplementation libs.mozilla.concept.fetch
}

The mozconfig bit is for future appsvc work, but you don't need to specifically test it yourself.

Otherwise, the change looks good. Thanks for trying it out.

bendk
bendk approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm confused at why you can't just remove the line, but that's probably just me not understanding gradle. In any case, I'm just wondering out-loud and I'm happy to merge this as is.

components/ads-client/android/build.gradle

dependencies {
api project(":httpconfig")
testImplementation project(":httpconfig")
Copy link
Contributor

@bendk bendk Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of curious why you even need testImplementation here. I can't see any for this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moztcampbell moztcampbell moztcampbell left review comments

@bendk bendk bendk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luc-lisi @bendk @moztcampbell